fix #19, tutorial update pycall (ex10)#21
Merged
Yushan-Wang merged 5 commits intomainfrom Jan 28, 2025
Merged
Conversation
jmorice91
requested review from
JAuriac,
Yushan-Wang,
benoitmartin88 and
jbigot
jmorice91
changed the title
Yushan-Wang
approved these changes
Dec 6, 2024
Yushan-Wang
approved these changes
Jan 22, 2025
JAuriac
reviewed
Jan 23, 2025
Comment on lines
+24
to
+40
| #*** the name of the PDI variable to write. | ||
| #... | ||
| dataset: main_field # name of the dataset in "ex10.h5" | ||
| dataset_selection: | ||
| size: [1, '$dsize[0]-2', '$dsize[1]-2'] | ||
| start: ['$ii-1', '$pcoord[0]*($dsize[0]-2)', '$pcoord[1]*($dsize[1]-2)'] | ||
| #*** load the pycall plugin and enable this plugin for event loop. | ||
| #... | ||
| #*** Specifies the input parameters (variables) to pass to Python as a set of "$-expressions" (expressions must be defined in .yml script) | ||
| #... | ||
| #*** add exec keyword of pycall plugin. Decomment and the following python script | ||
| #... | ||
| # import numpy as np | ||
| # if 0 < iter_id < 4: # iter_id: time iteration | ||
| # transformed_field = np.sqrt(source_field[1:-1,1:-1]) | ||
| # pdi.expose('transformed_field', transformed_field, pdi.OUT) | ||
| ## Comment: The last line allows to expose transformed field to PDI. Hence, the data is known by PDI in this call. |
Contributor
There was a problem hiding this comment.
Suggested change
| #*** the name of the PDI variable to write. | |
| #... | |
| dataset: main_field # name of the dataset in "ex10.h5" | |
| dataset_selection: | |
| size: [1, '$dsize[0]-2', '$dsize[1]-2'] | |
| start: ['$ii-1', '$pcoord[0]*($dsize[0]-2)', '$pcoord[1]*($dsize[1]-2)'] | |
| #*** load the pycall plugin and enable this plugin for event loop. | |
| #... | |
| #*** Specifies the input parameters (variables) to pass to Python as a set of "$-expressions" (expressions must be defined in .yml script) | |
| #... | |
| #*** add exec keyword of pycall plugin. Decomment and the following python script | |
| #... | |
| # import numpy as np | |
| # if 0 < iter_id < 4: # iter_id: time iteration | |
| # transformed_field = np.sqrt(source_field[1:-1,1:-1]) | |
| # pdi.expose('transformed_field', transformed_field, pdi.OUT) | |
| ## Comment: The last line allows to expose transformed field to PDI. Hence, the data is known by PDI in this call. | |
| #*** the name of the PDI variable to write | |
| #... | |
| dataset: main_field # name of the dataset in "ex10.h5" | |
| dataset_selection: | |
| size: [1, '$dsize[0]-2', '$dsize[1]-2'] | |
| start: ['$ii-1', '$pcoord[0]*($dsize[0]-2)', '$pcoord[1]*($dsize[1]-2)'] | |
| #*** load the pycall plugin and enable this plugin for event loop | |
| #... | |
| #*** specifies the input parameters (variables) to pass to Python as a set of "$-expressions" (expressions must be defined in .yml script) | |
| #... | |
| #*** add exec keyword of pycall plugin. Decomment and the following python script | |
| #... | |
| # import numpy as np | |
| # if 0 < iter_id < 4: # iter_id: time iteration | |
| # transformed_field = np.sqrt(source_field[1:-1,1:-1]) | |
| # pdi.expose('transformed_field', transformed_field, pdi.OUT) | |
| ## Comment: The last line allows to expose transformed field to PDI. Hence, the data is known by PDI in this call. |
Need to unify comment format for all files. As of now, some comments got no uppercase and no end dot, some only get the uppercase (as in ex10.c), and some have both.
Also need to modify to account for solution's indent (transformed_data).
Yushan-Wang
approved these changes
Jan 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.